Skip to content

Trigger iOS/Android/server CI on workflow-file changes#156

Merged
niteshbalusu11 merged 1 commit intomasterfrom
codex/trigger-ci-on-workflow-changes
Feb 14, 2026
Merged

Trigger iOS/Android/server CI on workflow-file changes#156
niteshbalusu11 merged 1 commit intomasterfrom
codex/trigger-ci-on-workflow-changes

Conversation

@niteshbalusu11
Copy link
Member

Summary

  • trigger iOS PR CI when .github/workflows/** files change
  • trigger Android and server push workflows on master when workflow files change
  • update client/server PR change detection to treat workflow-file edits as relevant changes
  • document agent post-merge requirement to sync local master in AGENTS.md and start.md

Why

Workflow-only PRs and merges can silently skip CI with path filters, which makes it hard to validate workflow updates. This ensures CI runs when workflows themselves are modified.

Files changed

  • .github/workflows/client.yml
  • .github/workflows/server.yml
  • .github/workflows/noah-maestro-test-ios.yml
  • .github/workflows/client-telegram.yml
  • .github/workflows/ios-telegram.yml
  • .github/workflows/server-push.yml
  • AGENTS.md
  • start.md

Validation

  • Parsed all workflow YAML files successfully.
  • Pre-commit hook passed: bun --cwd client check.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the continuous integration (CI) system by ensuring that CI workflows are triggered whenever the workflow definition files themselves are modified. This addresses a critical gap where workflow-only changes could bypass CI, making validation difficult. Additionally, it updates documentation to guide developers on syncing their local master branch after a pull request merge, improving development hygiene.

Highlights

  • CI Triggering: iOS PR CI will now trigger when .github/workflows/** files change.
  • Workflow Triggering: Android and server push workflows on master will now trigger when workflow files change.
  • Change Detection: Client/server PR change detection has been updated to treat workflow-file edits as relevant changes.
  • Documentation Update: The requirement for agents to sync their local master branch post-merge has been documented in AGENTS.md and start.md.
Changelog
  • AGENTS.md
    • Added instructions for agents to sync their local master branch after a PR is merged.
  • start.md
    • Updated the PR workflow steps to include syncing local master after a merge.
Ignored Files
  • Ignored by pattern: .github/workflows/** (6)
    • .github/workflows/client-telegram.yml
    • .github/workflows/client.yml
    • .github/workflows/ios-telegram.yml
    • .github/workflows/noah-maestro-test-ios.yml
    • .github/workflows/server-push.yml
    • .github/workflows/server.yml
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to trigger CI on workflow file changes and updates the developer/agent documentation accordingly. My review is based on the changes in AGENTS.md and start.md. The documentation updates are clear and add a crucial step for keeping the local master branch synchronized. I've suggested a minor improvement to use the more modern git switch command instead of git checkout for better clarity and adherence to current best practices. Overall, the documentation changes are a good addition to the agent workflow.

- `gh pr checks --watch`
- or `gh pr view --json statusCheckRollup`
- After PR is merged, sync local `master` before continuing work:
- `git checkout master`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For better clarity and to adhere to modern git command usage, consider using git switch master instead of git checkout master. The git switch command is specifically designed for changing branches and is less ambiguous than the multi-purpose git checkout command.

Suggested change
- `git checkout master`
- `git switch master`

4. After opening PR, monitor status checks:
- `gh pr checks --watch`
5. Once checks pass and PR is merged, sync local `master` immediately:
- `git checkout master`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To align with modern git best practices, it's recommended to use git switch master instead of git checkout master. The git switch command is clearer in its intent, as it's solely for switching branches, unlike the overloaded git checkout command.

Suggested change
- `git checkout master`
- `git switch master`

@niteshbalusu11 niteshbalusu11 merged commit 4c20a29 into master Feb 14, 2026
10 checks passed
@niteshbalusu11 niteshbalusu11 deleted the codex/trigger-ci-on-workflow-changes branch February 14, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments