Trigger iOS/Android/server CI on workflow-file changes#156
Trigger iOS/Android/server CI on workflow-file changes#156niteshbalusu11 merged 1 commit intomasterfrom
Conversation
Summary of ChangesHello @niteshbalusu11, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the continuous integration (CI) system by ensuring that CI workflows are triggered whenever the workflow definition files themselves are modified. This addresses a critical gap where workflow-only changes could bypass CI, making validation difficult. Additionally, it updates documentation to guide developers on syncing their local master branch after a pull request merge, improving development hygiene. Highlights
Changelog
Ignored Files
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to trigger CI on workflow file changes and updates the developer/agent documentation accordingly. My review is based on the changes in AGENTS.md and start.md. The documentation updates are clear and add a crucial step for keeping the local master branch synchronized. I've suggested a minor improvement to use the more modern git switch command instead of git checkout for better clarity and adherence to current best practices. Overall, the documentation changes are a good addition to the agent workflow.
| - `gh pr checks --watch` | ||
| - or `gh pr view --json statusCheckRollup` | ||
| - After PR is merged, sync local `master` before continuing work: | ||
| - `git checkout master` |
There was a problem hiding this comment.
For better clarity and to adhere to modern git command usage, consider using git switch master instead of git checkout master. The git switch command is specifically designed for changing branches and is less ambiguous than the multi-purpose git checkout command.
| - `git checkout master` | |
| - `git switch master` |
| 4. After opening PR, monitor status checks: | ||
| - `gh pr checks --watch` | ||
| 5. Once checks pass and PR is merged, sync local `master` immediately: | ||
| - `git checkout master` |
There was a problem hiding this comment.
To align with modern git best practices, it's recommended to use git switch master instead of git checkout master. The git switch command is clearer in its intent, as it's solely for switching branches, unlike the overloaded git checkout command.
| - `git checkout master` | |
| - `git switch master` |
Summary
.github/workflows/**files changemasterwhen workflow files changemasterinAGENTS.mdandstart.mdWhy
Workflow-only PRs and merges can silently skip CI with path filters, which makes it hard to validate workflow updates. This ensures CI runs when workflows themselves are modified.
Files changed
.github/workflows/client.yml.github/workflows/server.yml.github/workflows/noah-maestro-test-ios.yml.github/workflows/client-telegram.yml.github/workflows/ios-telegram.yml.github/workflows/server-push.ymlAGENTS.mdstart.mdValidation
bun --cwd client check.