fix: exclude package.json and package-lock.json from git export#213
fix: exclude package.json and package-lock.json from git export#213DASPRiD merged 2 commits intoBacon:mainfrom
Conversation
Also alphasort list
|
Can you quickly explain, why those need to be in gitattributes? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=========================================
Coverage 70.81% 70.81%
Complexity 994 994
=========================================
Files 49 49
Lines 3169 3169
=========================================
Hits 2244 2244
Misses 925 925 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Because they're not needed for people using the library (when installed via composer). AFAIS, the packages (if installed) are only for testing purposes? |
|
Ah yes, good point. Could you update the PR and also remove the Dockerfile? that one was removed from the repo. |
|
Also, I assume this change can be considered a chore and not a fix (so it doesn't warrant a patch release by itself)? |
I wouldn't complain if you did a point release for it, both files are relatively small... Some repos end up with large files, which is more annoying when you're committing the output elsewhere for say deployment reasons. |
|
Thank you so much for this PR ! |
Also alphasort list