Make EPS & SVG Rendering usable on international locales#177
Make EPS & SVG Rendering usable on international locales#177bardiir wants to merge 5 commits intoBacon:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #177 +/- ##
=========================================
Coverage 66.51% 66.51%
Complexity 993 993
=========================================
Files 49 49
Lines 3178 3178
=========================================
Hits 2114 2114
Misses 1064 1064 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Can you have a look at the failing checks? |
|
For convenience, links to the PRs mentioned in the first message:
Regarding:
The warnings are:
They seem to be irrelevant (note: these are actually modified lines, not added ones). As mentioned in #84 (comment):
And last not but least:
References:
Therefore, I suppose we no longer have to change the code at hand. |
|
@vlakoff Thanks, that's good to know. Want to supply a PR to revert that? |
Revisit pr#84 as pr#100 did not address nearly all instances of the rounding error. Amended the pull request with the solution presented in pr#100 adapted to all functions