-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Model integration with DT and online-deployment message #44261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR integrates default deployment template support for models in Azure ML SDK and adds informational messaging when deploying models with configured deployment templates. The changes include:
- Adding
defaultDeploymentTemplatefield to Model entities with proper serialization - Creating new
DefaultDeploymentTemplateclass for managing deployment template references - Updating deployment operations to check for and inform users about default deployment templates
- Modifying REST client code generation for proper field naming (camelCase in JSON)
- Updating swagger configuration and auto-generated REST client operations
Key Changes
- New
DefaultDeploymentTemplateentity class with schema support - Model entity extended with
default_deployment_templatefield - Deployment operations enhanced to display informational messages about default deployment templates
- Sample file demonstrating usage patterns
- Swagger configuration updated with new API version (v2025-04-01-preview)
- REST client operations auto-regenerated with style improvements
Reviewed changes
Copilot reviewed 45 out of 47 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| swagger/.../readme.md | Updated swagger configuration, fixed tag conditions, added v2025-04-01-preview |
| swagger/.../mfe.json | Changed field name from DefaultDeploymentTemplate to defaultDeploymentTemplate (camelCase) |
| samples/model_with_deployment_template_example.py | Example code demonstrating DefaultDeploymentTemplate usage (contains hardcoded credentials) |
| operations/_online_deployment_operations.py | Added credential parameter to upload_dependencies call |
| operations/_model_operations.py | Updated return type and imports for v2021_10_01_dataplanepreview models |
| operations/_deployment_template_operations.py | Temporarily changed endpoint to test environment |
| operations/_batch_deployment_operations.py | Added credential parameter to upload_dependencies call |
| entities/.../default_deployment_template.py | New entity class for deployment template references |
| entities/.../model.py | Added default_deployment_template field with serialization support |
| entities/init.py | Exported DefaultDeploymentTemplate class |
| _utils/_endpoint_utils.py | Added logic to check and log messages about default deployment templates |
| _schema/assets/model.py | Added schema field for default_deployment_template |
| _schema/assets/default_deployment_template.py | New schema for DefaultDeploymentTemplate |
| _restclient/v2021_10_01_dataplanepreview/operations/*.py | Auto-generated REST client operations with style improvements |
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
|
Please update changelog |
|
Please update samples as per code change. this sample code will be published in the ms public documentation: https://github.com/Azure/azure-sdk-for-python/tree/main/sdk/ml/azure-ai-ml/samples |
|
consider to add/update test cases wherever possible |
sdk/ml/azure-ai-ml/azure/ai/ml/entities/_assets/_artifacts/model.py
Outdated
Show resolved
Hide resolved
b3e47f2 to
2fccb86
Compare
f2dfe35 to
51dbb2e
Compare
Description
Please add an informative description that covers that changes made by the pull request and link all relevant issues.
If an SDK is being regenerated based on a new API spec, a link to the pull request containing these API spec changes should be included above.
All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines