[Peering] SDK validation for TypeSpec #54303
Open
+2,976
−2,374
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
HarveyLink
requested review from
ArcturusZhang and
ArthurMa1978
as code owners
Copilot finished reviewing on behalf of
HarveyLink
December 4, 2025 08:17
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Azure Peering SDK to validate against TypeSpec, migrating from API version 2022-10-01 to 2025-05-01. The changes include:
- Updated API version references across all generated files
- Modified specification paths to include
/Peering/subfolder structure - Added new connectivity probes functionality to peering resources
- Reordered methods in RestOperations files (moving List operations to precede Get/CreateOrUpdate)
- Updated parameter documentation from generic "Azure subscription ID" to "The ID of the target subscription"
- Added new configuration directives in autorest.md
Reviewed changes
Copilot reviewed 3 out of 93 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Sample_SubscriptionResourceExtensions.cs | Updated example paths, added new InitializePeeringServiceConnectionMonitor sample, reordered samples |
| Sample_PeeringServiceResource.cs | Updated example definition paths to new API version |
| Sample_PeeringServicePrefixResource.cs | Updated example definition paths to new API version |
| Sample_PeeringServicePrefixCollection.cs | Updated example definition paths to new API version |
| Sample_PeeringServiceCollection.cs | Updated example definition paths to new API version |
| Sample_PeeringResource.cs | Updated example definition paths to new API version |
| Sample_PeeringRegisteredPrefixResource.cs | Updated example definition paths to new API version |
| Sample_PeeringRegisteredPrefixCollection.cs | Updated example definition paths to new API version |
| Sample_PeeringRegisteredAsnResource.cs | Updated example definition paths to new API version |
| Sample_PeeringRegisteredAsnCollection.cs | Updated example definition paths to new API version |
| Sample_PeeringCollection.cs | Updated example paths, added ConnectivityProbes to peering creation samples |
| Sample_PeerAsnResource.cs | Updated example definition paths to new API version |
| Sample_PeerAsnCollection.cs | Updated example definition paths to new API version |
| Sample_ConnectionMonitorTestResource.cs | Updated example definition paths to new API version |
| Sample_ConnectionMonitorTestCollection.cs | Updated example definition paths to new API version |
| autorest.md | Updated require path, added lenient-model-deduplication, updated rename-mappings, modified directives |
| RestOperations files (13 files) | Updated API version to 2025-05-01, reordered methods, updated documentation, adjusted query parameter ordering |
| Resource files (6 files) | Updated API version references in XML documentation comments |
The changes appear to be primarily automated code generation updates with no apparent issues detected.
ArcturusZhang
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TSP PR: Azure/azure-rest-api-specs#38357
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.