Skip namespace approval check for mgmt plane #54283
Conversation
praveenkuttappan
requested review from
benbp,
hallipr and
weshaggard
as code owners
There was a problem hiding this comment.
Pull request overview
This PR modifies the APIView status check logic to skip namespace approval requirements for management plane packages during preview/prerelease releases. This allows mgmt plane preview packages to be released without waiting for APIView approval.
- Updated the path sourcing to use
Join-Pathfor better cross-platform compatibility - Added SemVer.ps1 import to enable semantic version parsing
- Implemented early return logic to skip APIView status checks for prerelease mgmt plane packages
| if ($null -eq $version) { | ||
| return $false | ||
| } | ||
| # Do not check APIView status for prerelease mgmt plane packages |
There was a problem hiding this comment.
I'm not sure of the context for WHY you're making this change, but I believe this would skip the "validate the package name" step that is an important part of the process.
@KrzysztofCwalina, @christothes, @m-nash, @ArthurMa1978: Would appreciate thoughts.
There was a problem hiding this comment.
@jsquire This will skip only for management plane and Arthur has signed off that change. Management plane follows different process for namespace approval and APIView was not supposed to gate check the package name approval for management plane and validate the apiview status only for GA releases. Change in https://github.com/Azure/azure-sdk-for-net/pull/43599/files introduced a bug that mandated namespace approval for .NET management plane also.
There was a problem hiding this comment.
What is their approval process?
There was a problem hiding this comment.
Service team creates an issue like Azure/azure-sdk#9441 and gets it approved. @ronniegeraghty coordinates this approval process. So APIView is not involved for mgmt plane package namespace approval.
There was a problem hiding this comment.
There was a problem hiding this comment.
And as I sent on the email, it is about consistency. Not saying the name is not going to get validated
|
Since there's open discussion and I'm going to be out, I'm going to @m-nash to take point on this and help drive to an outcome. We'll need @maririos to come to an agreement with @KrzysztofCwalina on the process and protections. If KC is in agreement, @m-nash can clear my blocker and let this move forward. |
5 participants
Skip apiview namespace approval check for mgmt plane for preview releases.
Fixes issue Azure/azure-sdk-tools#13080