{Compute} migrate vmss update-instances to aaz#32851
Open
{Compute} migrate vmss update-instances to aaz#32851
vmss update-instances to aaz#32851Conversation
huiii99
requested review from
jsntcy,
wangzelin007,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
Migrates az vmss update-instances from an SDK-based implementation to an AAZ-backed implementation within the VM command module, aligning this command with the ongoing AAZ migration effort.
Changes:
- Replaces the SDK call path in
update_vmss_instanceswith an invocation of the AAZManualupgradecommand. - Adds the generated AAZ command implementation for the VMSS manual upgrade endpoint.
- Exposes the new AAZ command via the VMSS AAZ package
__init__.py.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/azure-cli/azure/cli/command_modules/vm/custom.py |
Switches update_vmss_instances to call the AAZ command instead of the handwritten SDK flow. |
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/_manualupgrade.py |
Introduces the generated AAZ command implementation for VMSS manual upgrade (update-instances). |
src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/__init__.py |
Re-exports the new _manualupgrade command for import/use. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
vmss update-instancesDescription
Migrate
az vmss update-instancescommands from hand written sdk to aaz.aaz: Azure/aaz#951
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.