{Core} Increase threadpool timeout to 60 seconds. #32836
Merged
DanielMicrosoft merged 1 commit intoAzure:devfrom Feb 24, 2026
Merged
{Core} Increase threadpool timeout to 60 seconds. #32836DanielMicrosoft merged 1 commit intoAzure:devfrom
DanielMicrosoft merged 1 commit intoAzure:devfrom
Conversation
DanielMicrosoft
requested review from
ReaNAiveD,
bebound,
calvinhzy,
jiasli,
jsntcy,
kairu-ms,
necusjz and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
Auto-Assign
Contributor
There was a problem hiding this comment.
Pull request overview
This PR increases the module load timeout from 30 seconds to 60 seconds in the Azure CLI core. The timeout is used as a safety valve during parallel module loading to prevent indefinite hangs when loading command modules.
Changes:
- Doubled the MODULE_LOAD_TIMEOUT_SECONDS constant from 30 to 60 seconds
Comments suppressed due to low confidence (1)
src/azure-cli-core/azure/cli/core/init.py:40
- The comment "Timeout (in seconds) for loading a single module" is misleading. This timeout is used with
concurrent.futures.as_completed()on line 634, which means it's the timeout for waiting for the next completed future in the iteration, not a timeout for a single module's execution. Consider updating the comment to more accurately reflect this behavior, such as "Timeout (in seconds) for waiting for next module to complete during parallel loading. Acts as a safety valve to prevent indefinite hangs"
# Timeout (in seconds) for loading a single module. Acts as a safety valve to prevent indefinite hangs
MODULE_LOAD_TIMEOUT_SECONDS = 60
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
necusjz
approved these changes
Feb 24, 2026
DanielMicrosoft
modified the milestones:
April 2026 (2026-04-07),
March 2026 (2026-03-03)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Noticed occasional timeouts on WSL with
mntdrive, for the larger modules (vmfor example), increasing the timeout for threads as a safety measure.Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.