{Compute} az vmss reimage: Migrate command to aaz-based implementation#32790
Closed
william051200 wants to merge 2 commits intoAzure:devfrom
Closed
{Compute} az vmss reimage: Migrate command to aaz-based implementation#32790william051200 wants to merge 2 commits intoAzure:devfrom
az vmss reimage: Migrate command to aaz-based implementation#32790william051200 wants to merge 2 commits intoAzure:devfrom
Conversation
william051200
requested review from
jsntcy,
wangzelin007 and
yanzhudd
as code owners
❌AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
added
the
Compute
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the az vmss reimage command from the legacy SDK-based implementation (mgmt.compute) to a modern AAZ-based implementation. The migration is part of an ongoing effort to modernize Azure CLI by moving away from SDK clients to AAZ (Azure CLI Auto Rest) commands.
Changes:
- Replaces SDK-based
reimage_vmssimplementation with AAZ command invocations - Introduces two new AAZ command files:
_reimage.pyand_reimageall.py - Moves command registration from SDK-based command group to custom command group
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/azure-cli/azure/cli/command_modules/vm/custom.py | Refactored reimage_vmss function to use AAZ commands instead of SDK clients; maintains same logic flow (uses Reimageall when instance_ids provided, Reimage otherwise) |
| src/azure-cli/azure/cli/command_modules/vm/commands.py | Moved reimage command registration from SDK-based command group to custom command group (appropriate for AAZ implementation) |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/_reimage.py | New auto-generated AAZ command for VMSS reimage operation; supports instance_ids, force_update_os_disk_for_ephemeral, and additional parameters |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/_reimageall.py | New auto-generated AAZ command for VMSS reimage-all operation (reimages all disks including data disks) |
| src/azure-cli/azure/cli/command_modules/vm/aaz/latest/vmss/init.py | Added imports for new Reimage and Reimageall AAZ commands |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
william051200
force-pushed
the
vmss-reimage-migration
branch
from
ab243f2 to
c702bc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az vmss reimageDescription
Migration from mgmt.compute to aaz-based
aaz Azure/aaz#946
Testing Guide
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.