{CI} Remove Python 2 patch step in build scripts#32519
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
microsoft-github-policy-service
bot
requested review from
Pan-Qi,
bebound,
jiasli,
jsntcy,
kairu-ms,
wangzelin007 and
yonzhan
There was a problem hiding this comment.
Pull request overview
This PR removes the obsolete Python 2 patching step from the Windows build script. The patch_models_v2.py script was used to generate Python 2/3 compatible model files for AutoRest-generated SDKs, which is no longer necessary since Python 2 reached end-of-life and Azure CLI only supports Python 3.
Key Changes
- Removed the call to patch_models_v2.py from the Windows build script
- Eliminates build failures caused by the patching step interfering with the new SDK structure
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Q from @bebound: Based on the initial PR's description, it's used to Concatenate management sdk model files into 1 to minimize the file number in the installer. Does it only process Python2 SDK, does it still produce the same zip file after removing this step? A: i believe such logic is implied in the changes to the build.cmd (not patch_models_v2.py) of #7633. the following is the detailed experiment:
they are identical. hence, we can conclude that it still produces the same zip file after removing this step. |
Related command
Description
#32489 (comment)
the problem itself will cause pull requests based on the new sdk structure to fail in ci, e.g., #31949.
close: #32489
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.