Skip to content

Conversation

@ZhidongPeng
Copy link
Collaborator

Generated azure-proxy-agent.spec file by rust2rpm 27 and manual updated for deamon service install and local build

  • Added the source0 tarball file manually as the extracted folder name must be azure-proxy-agent instead of GuestProxyAgent
  • Added the source1 vendor tarball file to have rpm package build locally
  • Added patch0 to remove the unnecessary rust members and remove windows rust dependencies
  • Added patch1 and patch2 to fix %cargo_test

Executed the command at Fedora-Cloud-42-x64 Azure VM:

rpmbuild --define "_topdir $(pwd)/rpmbuild" -ba rpmbuild/SPECS/azure-proxy-agent.spec

Copy link
Member

@jeremycline jeremycline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of this should be checked into your repository.

You may maintain a specfile upstream if you want, but downstream distributions will maintain their own specfiles separately. Under no circumstances should you be checking any tarballs into your repository.

@ZhidongPeng
Copy link
Collaborator Author

ZhidongPeng commented Sep 30, 2025

None of this should be checked into your repository.

You may maintain a specfile upstream if you want, but downstream distributions will maintain their own specfiles separately. Under no circumstances should you be checking any tarballs into your repository.

I want to keep the spec file in current repo as upstream, are you suggesting creating another dedicated repo as our upstream?

per tarballs, both the source and vendor tarballs are temporary to make the spec built locally. I will prepare the source tar file to have the extracted folder name be azure-proxy-agent.

@jeremycline
Copy link
Member

None of this should be checked into your repository.
You may maintain a specfile upstream if you want, but downstream distributions will maintain their own specfiles separately. Under no circumstances should you be checking any tarballs into your repository.

I want to keep the spec file in current repo as upstream, are you suggesting creating another dedicated repo as our upstream?

Upstream of what? I don't understand what you're trying to achieve here. Do you want to use this to ship on packages.microsoft.com?

per tarballs, both the source and vendor tarballs are temporary to make the spec built locally. I will prepare the source tar file to have the extracted folder name be azure-proxy-agent.

You should not be checking any tarballs into your repository. This is git, nothing is temporary. Checking in huge blobs will remain in your history forever and your build process should not rely on this workflow.

@ZhidongPeng
Copy link
Collaborator Author

None of this should be checked into your repository.
You may maintain a specfile upstream if you want, but downstream distributions will maintain their own specfiles separately. Under no circumstances should you be checking any tarballs into your repository.

I want to keep the spec file in current repo as upstream, are you suggesting creating another dedicated repo as our upstream?

Upstream of what? I don't understand what you're trying to achieve here. Do you want to use this to ship on packages.microsoft.com?

per tarballs, both the source and vendor tarballs are temporary to make the spec built locally. I will prepare the source tar file to have the extracted folder name be azure-proxy-agent.

You should not be checking any tarballs into your repository. This is git, nothing is temporary. Checking in huge blobs will remain in your history forever and your build process should not rely on this workflow.

please suggest where to keep the rpmbuild/spec file.

yes, I am not going to check in these tarballs,

@jeremycline
Copy link
Member

None of this should be checked into your repository.
You may maintain a specfile upstream if you want, but downstream distributions will maintain their own specfiles separately. Under no circumstances should you be checking any tarballs into your repository.

I want to keep the spec file in current repo as upstream, are you suggesting creating another dedicated repo as our upstream?

Upstream of what? I don't understand what you're trying to achieve here. Do you want to use this to ship on packages.microsoft.com?

per tarballs, both the source and vendor tarballs are temporary to make the spec built locally. I will prepare the source tar file to have the extracted folder name be azure-proxy-agent.

You should not be checking any tarballs into your repository. This is git, nothing is temporary. Checking in huge blobs will remain in your history forever and your build process should not rely on this workflow.

please suggest where to keep the rpmbuild/spec file.

yes, I am not going to check in these tarballs,

Assuming you intend this to be used as a submission to Fedora, it'll eventually end up in a repository in src.fedoraproject.org. If you're trying to use this for PMC, I guess storing it in this repo is fine.

If this is for Fedora, I recommend carefully reading through the packaging guidelines, particularly the sections on macros, systemd, and downstream patches. You must use applicable macros for things like installation locations, pre/post/uninstall scriptlets for systemd, etc. Your patches should be submitted upstream, and since you're the upstream, you should fix the issues you're addressing there instead of trying to carry patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants