-
Notifications
You must be signed in to change notification settings - Fork 12
Add rpm spec file and tarball files for local rpm package build #279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
jeremycline
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
None of this should be checked into your repository.
You may maintain a specfile upstream if you want, but downstream distributions will maintain their own specfiles separately. Under no circumstances should you be checking any tarballs into your repository.
I want to keep the spec file in current repo as upstream, are you suggesting creating another dedicated repo as our upstream? per tarballs, both the source and vendor tarballs are temporary to make the spec built locally. I will prepare the source tar file to have the extracted folder name be azure-proxy-agent. |
Upstream of what? I don't understand what you're trying to achieve here. Do you want to use this to ship on packages.microsoft.com?
You should not be checking any tarballs into your repository. This is git, nothing is temporary. Checking in huge blobs will remain in your history forever and your build process should not rely on this workflow. |
please suggest where to keep the rpmbuild/spec file. yes, I am not going to check in these tarballs, |
Assuming you intend this to be used as a submission to Fedora, it'll eventually end up in a repository in src.fedoraproject.org. If you're trying to use this for PMC, I guess storing it in this repo is fine. If this is for Fedora, I recommend carefully reading through the packaging guidelines, particularly the sections on macros, systemd, and downstream patches. You must use applicable macros for things like installation locations, pre/post/uninstall scriptlets for systemd, etc. Your patches should be submitted upstream, and since you're the upstream, you should fix the issues you're addressing there instead of trying to carry patches. |
Generated azure-proxy-agent.spec file by rust2rpm 27 and manual updated for deamon service install and local build
azure-proxy-agentinstead ofGuestProxyAgentExecuted the command at
Fedora-Cloud-42-x64Azure VM: