don't push state with same url #293
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently navigating through documentation sometimes leads to duplicate history entries, also when navigating back to documentation page either from another documentation page or from different site, pushState not only add additional entry, but also removes all history in front.
Ensuring that pushState is done only if new url is not equal current resolves this. I see only one quirky downside - it is not possible to create multiple history entries by navigating to same documentation page.
Steps to reproduce:
OpenAPI Explorer DemoAuthenticationlink in the menuAuthenticationpageSign up for Authressat the bottom or typing a new url (e.g. example.com)Thank you @cbliard for discovering it opf/openproject#21484 (review)