Skip to content

Conversation

@TaylorZowtuk
Copy link

You had mixed up which register you were using to handle the character ascii for the batchprint in demo.s.

Also in batchprint you were entering the restore settings loops for all print codes except the one which you should have been.

Do you have any ideas why demo.s leaves a long line of colored texted in the mainCircleLoop? Is this intentional or is there another bug somewhere?

@AustinGrey
Copy link
Owner

Hi Taylor,

Thanks for the pull request - I have not developed GLIM in some time but it seems that there were definitely bugs I was not aware of. If I have a chance to review the request and test then I will merge.

@TaylorZowtuk
Copy link
Author

TaylorZowtuk commented Aug 13, 2019

Sorry for all the new commits. I should have done this work in a new branch. You can ignore commits 2989b1c, d951334, 8dc51b1, and 9d7cf26. There are two more bugfixes here and some corrections to formatting for these bugfixes.

Commit 86be669 is what was leading to the vertical bar not being cleared by the circle printing in demo.s. Basically when the circle job with row = -1 was given to batchprint it saw row = -1 which is the terminator so it terminated the rest of the batch. To fix it we just need to sanitize the input to batchprint in the printcircle subroutine first.

Commit b123229 fixes issues that could arise due to not bounds checking the negative directions of the terminal. This came up in some of my testing. When printing past the terminal in the negative direction it prints the escape sequence out to the terminal. Now we check for that and do nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants