Skip to content

initial commit rps #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fidelis0788 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

initial commit rps #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@
<script src="main.js"></script>
</head>
<body>
<h1>Hello World!</h1>
<hr/>
<div id="display-element"></div>
<button onclick="displayDate()">Click Me</button>
<hr/>


<h1>Let's play</h1>

</body>
</html>
71 changes: 19 additions & 52 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,62 +1,29 @@
// uses strict mode so strings are not coerced, variables are not hoisted, etc...
'use strict';

// brings in the assert module for unit testing
const assert = require('assert');
// brings in the readline module to access the command line
const readline = require('readline');
// use the readline module to print out to the command line
const rl = readline.createInterface({
input: process.stdin,
output: process.stdout
});

// the function that will be called by the unit test below
const rockPaperScissors = (hand1, hand2) => {

// Write code here
// Use the unit test to see what is expected
var hand1 = prompt("What is your choice ?");
var hand2 = prompt("What about yours ?");

if(hand1 == "" || hand2 =="") {
Copy link

@yousifS yousifS Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are not all the cases.

console.log("Input 1 is empty please try again")
}

// the first function called in the program to get an input from the user
// to run the function use the command: node main.js
// to close it ctrl + C
function getPrompt() {
rl.question('hand1: ', (answer1) => {
rl.question('hand2: ', (answer2) => {
console.log( rockPaperScissors(answer1, answer2) );
getPrompt();
});
});
else if(hand2 == ""){
console.log("Input 2 is empty please try again")
}
else if(hand1 === hand2 && hand1,hand2 ==['rock','paper','scissors']) {
Copy link

@yousifS yousifS Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the second part here is not correct. I think you are trying to verify that hand1 and hand2 are valid.

console.log ("It is a tie");
}
else if(hand1 === "rock" && hand2 === "paper"||hand1 ==="paper" && hand2 === "scissors"){
console.log("hand2 wins");
}
else if(hand1 === "rock" && hand2 === "scissors") {
console.log("hand1 wins")
}
else{
console.log('try again')

}

// Unit Tests
// You use them run the command: npm test main.js
// to close them ctrl + C
if (typeof describe === 'function') {

// most are notes for human eyes to read, but essentially passes in inputs then compares if the function you built return the expected output.
describe('#rockPaperScissors()', () => {
it('should detect a tie', () => {
assert.equal(rockPaperScissors('rock', 'rock'), "It's a tie!");
assert.equal(rockPaperScissors('paper', 'paper'), "It's a tie!");
assert.equal(rockPaperScissors('scissors', 'scissors'), "It's a tie!");
});
it('should detect which hand won', () => {
assert.equal(rockPaperScissors('rock', 'paper'), "Hand two wins!");
assert.equal(rockPaperScissors('paper', 'scissors'), "Hand two wins!");
assert.equal(rockPaperScissors('rock', 'scissors'), "Hand one wins!");
});
it('should scrub input to ensure lowercase with "trim"ed whitepace', () => {
assert.equal(rockPaperScissors('rOcK', ' paper '), "Hand two wins!");
assert.equal(rockPaperScissors('Paper', 'SCISSORS'), "Hand two wins!");
assert.equal(rockPaperScissors('rock ', 'sCiSsOrs'), "Hand one wins!");
});
});
} else {

// always returns ask the user for another input
getPrompt();

}