feat: amd-sev-snp draft and feature flags for confidential computing#352
feat: amd-sev-snp draft and feature flags for confidential computing#352
Conversation
jorgeantonio21
left a comment
jorgeantonio21
left a comment
There was a problem hiding this comment.
Looking good.
Left a few comments
jorgeantonio21
left a comment
jorgeantonio21
left a comment
There was a problem hiding this comment.
Looking great,
Left a few more comments in the current logic
atoma-state/src/migrations/20241202121152_node_public_key_rotation.sql
Outdated
Show resolved
Hide resolved
| /// Err(e) => eprintln!("Attestation failed: {}", e), | ||
| /// } | ||
| /// ``` | ||
| pub fn get_compute_data_attestation(attested_data: &[u8]) -> Result<SNPAttestationReport> { |
There was a problem hiding this comment.
This looks great to me, we do need to look further how to incorporate NVIDIA cc into these remote attestation generation.
There was a problem hiding this comment.
Yes, nvtrust port in progress.
…to feat/sev-snp-support
…maConfidentialComputeError
jorgeantonio21
left a comment
jorgeantonio21
left a comment
There was a problem hiding this comment.
Looks great overall. Let's wait until we have it tested and then we can merge :)
jorgeantonio21
left a comment
jorgeantonio21
left a comment
There was a problem hiding this comment.
Left some comments, which hopefully will help with the tests.
| @@ -0,0 +1,8 @@ | |||
| -- Create tasks table | |||
There was a problem hiding this comment.
This comment is not within context.
| @@ -0,0 +1,8 @@ | |||
| -- Create tasks table | |||
| CREATE TABLE IF NOT EXISTS node_public_key_rotations ( | |||
There was a problem hiding this comment.
I suggest instead of re-creating the node_public_key_rotations table, that was already created in a previous migrations, to instead alter it (in place).
Notice that you are creating the table if not exists, which already does, so your changes are not applied and you get a bunch of missing column related errors in the tests.
Instead, I would change the code to something along the lines:
ALTER TABLE node_public_key_rotations
DROP COLUMN tdx_quote_bytes,
ADD COLUMN tee_quote_bytes BYTEA NOT NULL,
ADD COLUMN tee_provider BYTEA NOT NULL;There was a problem hiding this comment.
Sounds good, will make this change
2 participants
TODO: