Add spectator mode with limited room view (#minor) #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spectators can view room information but with restricted serialization groups (get-room-spectator) that hide sensitive game data like targets and missions. Game masters retain full access despite having SPECTATING status.
- Remove unused SPECTATE_ROOM voter code and related unit tests - Add filter_var validation for spectate parameter to ensure boolean type - Fix incomplete test by renaming and adding proper test coverage for existing player rejoin scenario
ArthurJCQ
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
get-room-spectatorserialization group for limited data exposure to spectating players