-
Notifications
You must be signed in to change notification settings - Fork 10
WiP: Prototype generic lo blocks module #253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
WiP: Prototype generic lo blocks module #253
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a72d5123a9
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| q.keys( | ||
| "lo_blocks_module.page_last_visited", | ||
| scope_fields={ | ||
| 'student': {'values': q.variable('roster'), 'path': 'user_id'}, | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use supported q.keys parameters to avoid TypeError
The q.keys call here passes scope_fields, but the KEYS handler (hack_handle_keys in learning_observer/communication_protocol/executor.py) only accepts STUDENTS, STUDENTS_path, RESOURCES, and RESOURCES_path. When this DAG executes, dispatch_node calls the handler with **node, so the unexpected scope_fields keyword raises a TypeError and the module’s exports never resolve. Use the supported STUDENTS/RESOURCES parameters (as in other modules) or update the handler to accept scope_fields before shipping this module.
Useful? React with 👍 / 👎.
a72d512 to
9944f12
Compare
|
I have very mixed -- mostly negative -- feelings about merging his PR -- but positive feelings about leaving it open for a while for discussion. It's actually quite interesting to see. It's a very nice proof-of-concept / prototype. However, before merge, there is a broad range of issues, from:
Those would need to be discussed and explored. It is helpful to see some of the abstractions in place and how pieces fit together. We'll want something on both sides of the fence, though, before connecting. |
|
Interesting. Seeing the dashboard -- in my mind -- opened up an even bigger can of worms:
Nothing here is immediate, but thought I'd leave the thoughts in the PR as a reminder later. |
|
Providing more context. The dashboard here is just a prototype built using a new Nextjs application with our websocket hook to fetch and manage data from the communication protocol. A static version of this app could be built and served via the LO Blocks module in this PR. |
|
Depends on olxhub/lo-blocks#164 |

No description provided.