WiP Remaining conversions to support PMSS#181
Open
bradley-erickson wants to merge 4 commits intomasterfrom
Open
WiP Remaining conversions to support PMSS#181bradley-erickson wants to merge 4 commits intomasterfrom
bradley-erickson wants to merge 4 commits intomasterfrom
Conversation
Collaborator
Author
|
Last item to get converted is feature flags. This one is a little interesting since sometimes its a simple true/false and sometimes we want the specific sub-settings for that feature flag. |
Collaborator
Author
|
Per a conversation with Piotr. Perhaps we try implementing something similar to CSS Keyframes (used in animations to define the css at different points along the animation) to support lists or dictionaries. @list xyz {
0 { setting: 123; }
1 { setting: 456; }
...
}OR @dict xyz {
item1 { setting: 123; }
item2 { setting: 456; }
...
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.