Skip to content

WiP Remaining conversions to support PMSS#181

Open
bradley-erickson wants to merge 4 commits intomasterfrom
berickson/202410-pmss-conversions
Open

WiP Remaining conversions to support PMSS#181
bradley-erickson wants to merge 4 commits intomasterfrom
berickson/202410-pmss-conversions

Conversation

@bradley-erickson
Copy link
Collaborator

No description provided.

@bradley-erickson
Copy link
Collaborator Author

Last item to get converted is feature flags. This one is a little interesting since sometimes its a simple true/false and sometimes we want the specific sub-settings for that feature flag.
Both auth_headers_page and merkle expect a dictionary to be returned.

@bradley-erickson
Copy link
Collaborator Author

bradley-erickson commented Oct 8, 2024

Per a conversation with Piotr. Perhaps we try implementing something similar to CSS Keyframes (used in animations to define the css at different points along the animation) to support lists or dictionaries.
So maybe something like:

@list xyz {
  0 { setting: 123; }
  1 { setting: 456; }
  ...
}

OR

@dict xyz {
  item1 { setting: 123; }
  item2 { setting: 456; }
  ...
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant