fix: Adjust theme for Material 3 changes#134
Open
soeren-schmaljohann-2denker wants to merge 39 commits intomainfrom
Open
fix: Adjust theme for Material 3 changes#134soeren-schmaljohann-2denker wants to merge 39 commits intomainfrom
soeren-schmaljohann-2denker wants to merge 39 commits intomainfrom
Conversation
soeren-schmaljohann-2denker
changed the title
ABausG
reviewed
Nov 29, 2023
Contributor
ABausG
left a comment
ABausG
left a comment
There was a problem hiding this comment.
Some tints still seem to look weird. Maybe also take a look into adding a golden test for Bottom Sheets to make sure they look correct in terms of shape and tint as well.
Contributor
There was a problem hiding this comment.
This looks like an unwanted tint on the dialogs
Contributor
There was a problem hiding this comment.
The tint of the switch in an unselected state looks wrong
…y to be able to test
…lutter rather than dart
github-actions
bot
added
p:core
github-actions
bot
added
the
p:user_management
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the global theme changes, the rest will be done in the individual apps, with seperate PRs.