Fix build pagination iteration parameters#34
Merged
Conversation
mattfoxvog
approved these changes
Jan 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
The
AutoBuilderHelperhandles communication with PublicApi for autodetecting the latest version of an app. To handle this, we need to handle the pagination of the public API responses to ensure that we get the latest build containing an attachment.Public API Pagination is 1 index, as opposed to 0 indexed, so we needed to extend out for loop to include the "totalPages" index, which would be the last page.
Additionally, we were not passing a field into the sort parameter, which caused us to get an unsorted response. This shouldn't affect the results, but we would rather receive the newest builds in earlier pages, in case we want to make this more efficient in the future.
I also added more unit tests to test this functionality to ensure that it does not break in future versions