Merged
Conversation
Update the `TransactionMgr` to implement the new `TxInterface`. This change simplifies the dependency injection and improves code organization. The `GetTxNum` method is added to satisfy the interface.
Replaced the `transaction` import with `txinterface` in `log_record.go`. This improves modularity and allows for greater flexibility in transaction management.
Refactor unified update log record serialization and deserialization for improved efficiency and error handling. Add constant for unified update operation.
Improved the `WriteToLog` function in `recoveryMgr.go` to correctly handle pointer arguments for `logManager`, `block`, and to ensure proper logging of transaction updates. This resolves issues with incorrect log record creation.
Added an `InsertCell` method to the `TxInterface` to allow inserting cells into the transaction. This enhances the functionality for managing cell insertions within transactions.
The changes in this commit convert several integer types to `int32` to improve the consistency and prevent potential integer overflow issues. This addresses the `java.lang.RuntimeException: An error occurred while streaming the request` error. The `int` type was insufficient for handling large block numbers, leading to unexpected behavior. The updated code uses `int32` for all relevant block-related variables to ensure proper handling of potentially larger values.
…tures for error handling #5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.