feat: Add RoPE Embedding challenge (Medium) #136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emharsha1812
requested review from
ishaan-arya and
kunal-mansukhani
as code owners
Contributor
|
@23silicon Can you make the spec the correct format, add more functional tests, and add JAX starter code |
| import jax | ||
| import jax.numpy as jnp | ||
|
|
||
| #Q, cos, sin are tensors on the GPU |
Contributor
There was a problem hiding this comment.
Need space between # and Q
|
|
||
| #Q, cos, sin are tensors on the GPU | ||
| @jax.jit | ||
| def solve(Q: array, cos: array, sin: array, output: array, M: int, D: int) -> jax.Array: |
Contributor
There was a problem hiding this comment.
jax.Array, not array
Contributor
There was a problem hiding this comment.
no output. It's returned
kunal-mansukhani
approved these changes
Jan 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new Medium difficulty challenge: Rotary Positional Embedding (RoPE).
RoPE is a critical component in modern LLMs (Llama 2/3, Mistral, etc.). I noticed that Unsloth recently added optimized RoPE kernels to their main repo, so I thought it would be a great addition to LeetGPU for users to practice implementing this fundamental operation.
Challenge Details
challenges/medium/61_rope_embeddingchallenge.py.Verification
challenge.pyreference implementation verified against standard formula.