[pull] master from bitcoin:master #1457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, there are issues with headers in `batchpriority.cpp`: 1. `SCHED_BATCH` is not defined on all supported *BSD platforms. 2. `pthread.h` is necessary on other platforms. This addresses both issues and fixes other includes.
…rrors efcbf79 ci, iwyu: Fix warnings in `src/zmq` and treat them as errors (Hennadii Stepanov) Pull request description: This PR [continues](#33725 (comment)) the ongoing effort to enforce IWYU warnings. See [Developer Notes](https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md#using-iwyu). Additionally, this adds a new include category to `src/.clang-format`. ACKs for top commit: maflcko: review ACK efcbf79 🐼 janb84: re ACK efcbf79 sedited: ACK efcbf79 Tree-SHA512: 5396719d4a9f7fff7b57be7284af5b25ff055edbaba417187e29106c9e310f19f361fbeea74e2448ef1e883a8658028762a38664858a863e5019fcb0cbb346a2
9c839aa iwyu: Document mappings for libc symbols (Hennadii Stepanov) 9182464 iwyu: Add temporary mapping to work around upstream bug (Hennadii Stepanov) 37de7d1 iwyu: Drop backported mapping (Hennadii Stepanov) Pull request description: This PR: 1. Removes mappings that have been [backported](include-what-you-use/include-what-you-use#1706) upstream. 2. Adds a new temporary mapping to work around upstream [issue](include-what-you-use/include-what-you-use#1616). 3. Document the existing mappings for libc symbols. ACKs for top commit: maflcko: lgtm ACK 9c839aa sedited: ACK 9c839aa Tree-SHA512: 691fd9fc6798951ca1a621ee607a617ebef2ed2f43196465c78c6cd7a5ea7f0f0e876e68cd54653edf9b6762ae5fdb704469a1524a5f6f1ab8b0eedbff65cc28
07af50f util: Drop *BSD headers in `batchpriority.cpp` (Hennadii Stepanov) Pull request description: Currently, there are issues with headers in `batchpriority.cpp`: 1. `SCHED_BATCH` is not defined on all supported *BSD platforms. 2. `pthread.h` is necessary on other platforms. This PR addresses both issues and fixes other includes. ACKs for top commit: maflcko: review ACK 07af50f 🤺 w0xlt: crACK 07af50f Tree-SHA512: 388f627e9d9c8b80834ba562034cd6aa44ba37d9156e13cdd6cbcfa93b19fcbf3222228d671784ca363e06fda3c978778f62f4530c3eb4ae3ff96adf91c2d789
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )