[pull] master from bitcoin:master #1456
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show that `CoinGrider` halts searching when the number of attempts exceeds `TOTAL_TRIES`. To do so, show that a solution is found, then add one more entry to the same set of inputs. Since the search orders by `effective_value`, the solution is constructed such that only values with the lowest `effective_value` have the least weight. Only the lowest weight values will not exceed the `max_selection_weight`. Therefore, `CoinGrinder` will not evaluate all lowest weight solutions together before exceeding `TOTAL_TRIES` since they are last found. This test case was inspired by a similar test for `BnB` currently named `bnb_test`.
Updates documentation and wallet_miniscript_decaying_multisig_descriptor_psbt.py to use single multipath descriptors with <0;1> syntax instead of separate external/internal descriptors. Changes: - doc/descriptors.md: Update examples to use /<0;1>/* multipath syntax with /0 and /1 notation - doc/descriptors.md: Update Basic Multisig Example instructions - test: Refactor to use single multipath descriptor pattern, matching wallet_multisig_descriptor_psbt.py Implementation: - _get_xpub() extracts external descriptor and converts to multipath format - create_multisig() builds descriptor string, gets checksum, imports descriptor#checksum - Multipath descriptor properly expands to external and internal/change descriptors Fixes #34086
…nked test 552bc82 doc: Use multipath descriptors in descriptors.md and linked test (Anurag chavan) Pull request description: Updates documentation and `wallet_miniscript_decaying_multisig_descriptor_psbt.py` to use single multipath descriptors with `<0;1>` syntax instead of separate external/internal descriptors. ## Changes - **doc/descriptors.md**: Update examples (lines 70-71) to use `/<0;1>/*` multipath syntax - **doc/descriptors.md**: Update Basic Multisig Example instructions (line 179) to use single multipath descriptor - **test/functional/wallet_miniscript_decaying_multisig_descriptor_psbt.py**: Refactor to use single multipath descriptor pattern matching `wallet_multisig_descriptor_psbt.py` ## Implementation - `_get_xpub()` now extracts external descriptor and converts to multipath format - `create_multisig()` imports single descriptor that expands to receive and change addresses - Removed fake checksums from documentation examples - Added clear comments documenting multipath convention Fixes #34086 ACKs for top commit: yashbhutwala: ACK 552bc82 achow101: ACK 552bc82 rkrux: lgtm tACK 552bc82 Tree-SHA512: cc99271a3955daa475242d9f4ef8f09f4c94c64e48ec4647ecfd95dceb38bb0cdd91b78ec2d5f033b449d175eaecbdda49d6c766c8a1e1a01fed93be4eb0cfc0
…tion remains b189a34 test: add case where `TOTAL_TRIES` is exceeded yet solution remains (yancy) Pull request description: Show that `CoinGrider` halts searching when the number of attempts exceeds `TOTAL_TRIES`. To do so, show that a solution is found, then add one more entry to the same set of inputs. Since the search orders by `effective_value`, the solution is constructed such that only values with the lowest `effective_value` have the least weight. Only the lowest weight values will not exceed the `max_selection_weight`. Therefore, `CoinGrinder` will not evaluate all lowest weight solutions together before exceeding `TOTAL_TRIES` since they are last found. This test case was inspired by a similar test for `BnB` currently named `bnb_test`. ACKs for top commit: frankomosh: Code review ACK b189a34 achow101: ACK b189a34 murchandamus: ACK b189a34 Tree-SHA512: 1df0b6e29ae219edbeed14cfa97f0ad4688d6bf97ed946719ba3c3b69e004f3dee82991578eb5aceb554914b70c5b68feff9e321283c1fc8bc0fedf08df2cb4c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )