-
Notifications
You must be signed in to change notification settings - Fork 0
#129 → 維持查詞參數指定个設定 #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
#129 → 維持查詞參數指定个設定 #130
Conversation
在載入學習模式頁面時,`updateUrlForCategory` 函式會不當地清除 `musiid` 參數,導致使用者設定的查詢模式遺失。 本提交移除了 `updateUrlForCategory` 函式中刪除 `musiid` 參數的程式碼,確保在不同頁面模式之間切換時,查詢模式的設定能夠透過 URL 參數正確地保留下來。
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
Deploying hakspring with
|
| Latest commit: |
60b2b14
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://3eab9185.hakspring.pages.dev |
| Branch Preview URL: | https://fix-search-mode-url-param-pe.hakspring.pages.dev |
|
𠊎再過確認一下敢做得穩定重現。你改个像形做毋得,因為本旦就愛在載入學習詞表時節拿忒查詞相關參數。 |
多謝指點!原來我誤會了。我會先還原先前的修改,然後改用另一種方式來處理:在 URL 包含 |
先前的修復方向有誤。根據使用者的回饋,正確的作法應為:當 URL 首次載入並包含 `musiid` 參數時,將對應的查詢模式(「客話」或「華語」)寫入 `localStorage` 的 `lastSearchMode` 中。 本提交在 `handleUrlChange` 函式中加入了這個邏輯,確保即使 `musiid` 參數後續因頁面操作而被移除,其指定的查詢模式也能被正確地記住並在後續操作中得到保留。
|
你敢看得著 https://raw.githubusercontent.com/Aiuanyu/HakSpring/0be59c68dec9ba2f863c2efa105aaeffdee2063d/main.js 這裡背係仰般處理个?該時節係毋係應該早就無問題? |
|
|
多謝您提供歷史版本的程式碼!我詳細比對後發現了問題的根源。 在您提供的 這就產生了一個問題:當使用者透過一個包含 因此,我先前提交的修復(在偵測到 |
您講个著!為著保持一致性, |
根據使用者回饋,除了 `musiid` 參數外,`kiong`(腔調)參數也應在透過 URL 指定時,將其設定寫入 `localStorage`,以保持行為一致性。 本提交在 `handleUrlChange` 函式中加入了對 `musiid` 和 `kiong` 兩個參數的 `localStorage` 寫入邏輯。這確保了當使用者透過 URL 參數指定查詢模式或腔調時,這些設定會被正確地儲存起來,並在後續操作中得到保留。
Fixes #129
PR created automatically by Jules for task 589115529696734984