Fix SSRF bypass via curl callback EventCache corruption #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firewall used a global
EventCachesingleton that was reset at every hook entry. When curl callbacks (CURLOPT_WRITEFUNCTION, etc.) invoked hooked PHP functions likefile_put_contents(), nested hooks corrupted the outer hook's context. ThePOSThandler then read empty values and skipped SSRF validation entirely.Summary by Aikido
⚡ Enhancements
🐛 Bugfixes
🔧 Refactors
More info