Skip to content

Remove users longer than 3 months for longer lists #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omit01 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove users longer than 3 months for longer lists #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion application/pages/default/ConsumePage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,20 +39,35 @@ public function beforeView()
usort($byFirstName, function($a, $b) {
return strcmp(strtolower($a[User::FIELD_FIRST_NAME]), strtolower($b[User::FIELD_FIRST_NAME]));
});
$byFirstName = array_filter($byFirstName, function($a) {
$timeStamp = strtotime($a['time']);
$cutOffDate = strtotime('-6 months');
Copy link
Owner

@Addono Addono Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 months where PR says 3 months 😕


return ($timeStamp > $cutOffDate);
});

$byLastName = $allUsersByRole[Role::ROLE_USER];
usort($byLastName, function($a, $b) {
return strcmp(strtolower($a[User::FIELD_LAST_NAME]), strtolower($b[User::FIELD_LAST_NAME]));
});
$byLastName = array_filter($byLastName, function($a) {
$timeStamp = strtotime($a['time']);
$cutOffDate = strtotime('-6 months');

return ($timeStamp > $cutOffDate);
});
Comment on lines +53 to +58
Copy link
Owner

@Addono Addono Nov 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code quality wise I would have factored out the filter function into a separate named function. Then both filters can use the same logic twice.

DRY for only two instances of the code is often just an edge care. So I'm fine keeping it like this. More of a general remark.


$byAmount = $allUsersByRole[Role::ROLE_USER];
usort($byAmount, function($a, $b) {
return $b['amount'] - $a['amount'];
});

$byLatest = $allUsersByRole[Role::ROLE_USER];
usort($byLatest, function($a, $b) {
$timeStamp1 = strtotime($a['time']);
$timeStamp2 = strtotime($b['time']);
return $timeStamp2 - $timeStamp1;
});;
});

$tabs = [
'ordered-first-name' => [
Expand Down