This repository was archived by the owner on Jan 17, 2025. It is now read-only.
Drop test-double and its dep quibble, use simple DateTime stubbing instead #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [testdouble](https://github.com/testdouble/testdouble.js) from 3.16.1 to 3.20.2. - [Changelog](https://github.com/testdouble/testdouble.js/blob/main/CHANGELOG.md) - [Commits](testdouble/testdouble.js@v3.16.1...v3.20.2) --- updated-dependencies: - dependency-name: testdouble dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
bantic
changed the title
mixonic
approved these changes
Jan 13, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops testdouble as a dependency.
#25 showed that newer testdouble versions result in an odd CI failure (
ENOENTerror while trying torequire('node:worker_threads')) that came from a 2ndary dep upgrade of "quibble"We were only using testdouble to stub
Luxon.DateTime.now|utcin a handful of places. This PR drops the dep and uses simple property reassignment to do the stubbing.