Skip to content

Bigger settings#12

Open
OlsonBolson-dev wants to merge 2 commits intoAdaelynXIV:mainfrom
OlsonBolson-dev:patch-1
Open

Bigger settings#12
OlsonBolson-dev wants to merge 2 commits intoAdaelynXIV:mainfrom
OlsonBolson-dev:patch-1

Conversation

@OlsonBolson-dev
Copy link

Made settings bigger, not a whole window, but is easier to read
Idea from @ghoomy from #9

Made settings bigger, not a whole window, but is easier to read
Idea from @ghoomy from AdaelynXIV#9
Settings modal was getting very thin in some places - fixed
@ItsdMeSoFYou
Copy link

The owner of this repository unfortunately doesn't want other people contributing to her project as it seems. My pull request is left unanswered since over a month

@OlsonBolson-dev
Copy link
Author

well, bad for her shrug, i hope people will use it

@heldheld
Copy link

heldheld commented Mar 6, 2023

Unfortunately, this seems to break the ability to interact with ChannelTabs. I can't seem to get it to work together with the ChannelTabs CSS link fix.

@OlsonBolson-dev
Copy link
Author

@heldheld alrighty, I'll fix it later

@heldheld
Copy link

heldheld commented Mar 6, 2023

@heldheld alrighty, I'll fix it later

That would be amazing, thanks :)
(the small settings menu is borderline unusable with the added lag)

@OlsonBolson-dev
Copy link
Author

@heldheld it seems the problem is on the main branch side, I don't belive this pull request is breaking it.

I think I know what couses the issue: .platform-win .typeWindows-2-g3UY is covering ChannelTabs' tab. I won't havetime to fix it till friday, so if someone wannna do it quicker go ahead

@heldheld
Copy link

heldheld commented Mar 7, 2023

@heldheld it seems the problem is on the main branch side, I don't belive this pull request is breaking it.

I think I know what couses the issue: .platform-win .typeWindows-2-g3UY is covering ChannelTabs' tab. I won't havetime to fix it till friday, so if someone wannna do it quicker go ahead

Aaahh right! I was already wondering why this would mess with the ChannelTabs' tab.
With that information, I managed to fix it for myself.
I edited lines 507 to 512 with these following values, and together with your settings window fix it works perfect for me now:

/* Makes toolbar an interactable bar again */
.platform-win .typeWindows-2-g3UY {
top:11px;
height:0px;
left: calc((var(--spacing) - var(--spacing)) - (var(--spacing) + 11px));
}

Don't know how resolution-depended it is, but I use 1440p monitors with 100% scaling.

@OlsonBolson-dev
Copy link
Author

@heldheld Won't it make the titlebar unusable? cuz if height is 0 that means you can't touch the titlebar, so you can't move the window, am I right?
If I were you I'd set height to 15-20px.
I have an idea to make it work well, but I will work on it on Friday maybe Thursday

@heldheld
Copy link

heldheld commented Mar 7, 2023

@heldheld Won't it make the titlebar unusable? cuz if height is 0 that means you can't touch the titlebar, so you can't move the window, am I right? If I were you I'd set height to 15-20px. I have an idea to make it work well, but I will work on it on Friday maybe Thursday

Oh, yeah you're right. I use AltDrag (or a variation I made) to move windows around, so I didn't notice. It looks fine though xD.

I'll await your (probably much better) version! :)

@OlsonBolson-dev
Copy link
Author

i have no idea what i'm doing xD

@OlsonBolson-dev
Copy link
Author

OlsonBolson-dev commented Mar 8, 2023

I'll await your (probably much better) version! :)

@heldheld Well I found spare hour and did something - #15
I guess it's not ideal, but it works fine

@OlsonBolson-dev OlsonBolson-dev linked an issue Mar 8, 2023 that may be closed by this pull request
@heldheld
Copy link

heldheld commented Mar 8, 2023

I'll await your (probably much better) version! :)

@heldheld Well I found spare hour and did something - #15 I guess it's not ideal, but it works fine

Thanks! It's a good solution, I can't really expect much more from a modded and altered version of an application that does not officially support those modifications. Thanks for putting in the time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make settings take up the whole window

3 participants