-
Notifications
You must be signed in to change notification settings - Fork 0
Docs, Admin, OCR, & Shortcuts #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: Anurag <anuragdhungana5@gmail.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| All admin endpoints require authentication via session token. | ||
|
|
||
| **Authentication Method:** Cookie-based sessions | ||
|
|
||
| **Required Cookie:** `admin_session_token` | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Admin auth cookie name documented incorrectly
The Admin API section lists the required cookie as admin_session_token, but the authentication middleware actually sets and checks the admin_session cookie (lib/admin-auth.ts lines 6–36). Following the documented name will result in every admin request being rejected with 401 despite a valid session token, so the docs need to reflect the cookie name the API enforces.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tembo fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the cookie name in the documentation from admin_session_token to admin_session to match what's actually used in the authentication middleware.
Summary
Added comprehensive documentation for API, contributing, and keyboard shortcuts. Implemented Admin Dashboard, Receipt Scanning with HEIC/HEIF support, and enhanced keyboard shortcuts with a help dialog. Integrated PostHog Analytics and fixed keyboard shortcut input conflicts.
Changes Made
API_REFERENCE.md,CONTRIBUTING.md,KEYBOARD_SHORTCUTS.md.README.mdwith links to new documentation.N,P,C,S,?) and introduced a dedicated help dialog.todo.mdby removing completed tasks.Testing
Screenshots (if applicable)
[Add screenshots here]
Related Issues
Closes #ca525212-8581-4ffd-bd22-84bcb44331ea