Skip to content

Comments

🐛 Fix for Variable Name in Triangle Instrument Class#27

Open
Kianzahrai wants to merge 1 commit intoAVMf:masterfrom
Kianzahrai:bug/#26_Variable_Name_Triangle_classify_instrument
Open

🐛 Fix for Variable Name in Triangle Instrument Class#27
Kianzahrai wants to merge 1 commit intoAVMf:masterfrom
Kianzahrai:bug/#26_Variable_Name_Triangle_classify_instrument

Conversation

@Kianzahrai
Copy link

Per issue #26, this PR aims to resolve the issue, and only this issue.

This is a bug I came across when studying the AVM framework as part of my search (no pun intended) and study of local heuristic search algorithms (alongside Hill Climbing and Simulated Annealing). During my study, I was constructing a CFG (Control-Flow Graph) for some methods throughout the framework, and when attempting on the classify method in this Triangle class, I wanted to raise this issue.

The change is very simple, but I won't say it "must be" approved before other reviewers are involved.

In terms of adding labels (I am not able to), I would suggest adding the "bug" label to this.

Note: the strikethrough criteria are not applicable to this PR.

  • Give it a descriptive title
  • Include language that will close all issues it is proposing fixes for
  • Describe any issues that it is proposing to fix that are not in the issue tracker to give a greater idea as to why the pull request should be approved
  • Fully describes all of the changes it is proposing and why succinctly states why they should be approved
  • Add any labels that apply to it
    • or suggest labels if you do not have permission to add them
  • includes all relevant updates to documentation if warranted by the proposed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant