🐛 Fix for Variable Name in Triangle Instrument Class#27
Open
Kianzahrai wants to merge 1 commit intoAVMf:masterfrom
Open
🐛 Fix for Variable Name in Triangle Instrument Class#27Kianzahrai wants to merge 1 commit intoAVMf:masterfrom
Kianzahrai wants to merge 1 commit intoAVMf:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per issue #26, this PR aims to resolve the issue, and only this issue.
This is a bug I came across when studying the AVM framework as part of my search (no pun intended) and study of local heuristic search algorithms (alongside Hill Climbing and Simulated Annealing). During my study, I was constructing a CFG (Control-Flow Graph) for some methods throughout the framework, and when attempting on the
classifymethod in thisTriangleclass, I wanted to raise this issue.The change is very simple, but I won't say it "must be" approved before other reviewers are involved.
In terms of adding labels (I am not able to), I would suggest adding the "bug" label to this.
Note: the strikethrough criteria are not applicable to this PR.
Describe any issues that it is proposing to fix that are not in the issue tracker to give a greater idea as to why the pull request should be approvedincludes all relevant updates to documentation if warranted by the proposed changes