Add logo and list of the features to README.md#19
Open
vrozin wants to merge 1 commit intoAVMf:masterfrom
Open
Conversation
enpuyou
requested changes
Apr 9, 2019
Collaborator
There was a problem hiding this comment.
Hi @vrozin, thank you so much for working on this issue. The content looks good! I apologize for not reviewing this PR sooner. We have been setting up the Travis CI with style guides check and lint tools for the project. With that said, can you please update your branch to the fix-readme branch, which now passes the build. And once your branch passes the Travis CI build, we will be able to merge in your PR. Thank you very much!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Alternate Designs
The logo can be relocated/resized.
The list can be modified.
Benefits
Possible users of the framework will be able to see what the framework can be used for.
Possible Drawbacks
N/A
Applicable issues
Fixes #17