fix mis-traversal on addrvars caused by iterator invalidation in conn…#24
Open
clingfei wants to merge 1 commit intoARISTODE:mainfrom
Open
fix mis-traversal on addrvars caused by iterator invalidation in conn…#24clingfei wants to merge 1 commit intoARISTODE:mainfrom
clingfei wants to merge 1 commit intoARISTODE:mainfrom
Conversation
…ectFormalInTreeWithAddrVars
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Insert to unordered_set will cause iterator invalidation once rehash occurred.
This will result in fewer PARAMETER_IN edges being generated than actually.
For example，when I use PDG to analyze function ixgbe_intr in ixgbe.ko.ll, the actual addr_var of arg %1 is :
while only following inst nodes is connected by PARAMETER_IN edge with root_node due to incorrect traversal and insertion, which will cause data-flow incomplete in latter analysis: