fix some bugs that may cause segment fault or crash

[clingfei]

1. When using arg_formal_in_tree to construct arg_actual_out_tree or other trees, it will call pdg::TreeNode::TreeNode(const TreeNode &tree_node), but its _parent_node field remains uninitialized. While in expandNode(), new_child_node will call computeDerivedAddrVarsFromParent(), in which may access root_node's parent_node through getParentNode(), while root_node's parent_node is still uninitialized, if its value is illegal, when use it as pointer, such as grand_parent_node->getAddrVars(), there will be a segment fault.
2. I have met a confusing case, in pdg::ProgramDependencyGraph::connectInterprocDependencies, for indirect calls, the number of nodes for caller's ret_actual_in_tree and callee's ret_formal_in_tree may unequal, which will cause assert(src->numOfChild() == dst->numOfChild()); in pdg::ProgramDependencyGraph::connectInTrees failed, so for each indirectCallCandidate, check the number of tree nodes before call connectCallerAndCallee, only when callee's nodes equals to caller's nodes, callee can be indeed indirectCallCandidate

[ARISTODE]

Thanks a lot for the in-depth code review! Could you maybe provide the code you tested (or provide a link to the tested repo)? I would need to verify the fixes and will merge the pull request after that.

[clingfei]

Thanks for review! I have added the test code to https://github.com/clingfei/test_repo.

…

------------------ 原始邮件 ------------------ 发件人: "ARISTODE/program-dependence-graph" ***@***.***>; 发送时间: 2023年4月8日(星期六) 晚上11:36 ***@***.***>; ***@***.******@***.***>; 主题: Re: [ARISTODE/program-dependence-graph] fix some bugs that may cause segment fault or crash (PR #17) Thanks a lot for the in-depth code review! Could you maybe provide the code you tested (or provide a link to the tested repo)? I would need to verify the fixes and will merge the pull request after that. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>