refactoring: Introduce Reservation dataclass#1053
Merged
jamOne- merged 17 commits intoAI-Hypercomputer:mainfrom Feb 13, 2026
Merged
refactoring: Introduce Reservation dataclass#1053jamOne- merged 17 commits intoAI-Hypercomputer:mainfrom
jamOne- merged 17 commits intoAI-Hypercomputer:mainfrom
Conversation
This reverts commit cdb3315.
scaliby
approved these changes
Feb 13, 2026
SikaGrr
approved these changes
Feb 13, 2026
FIoannides
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Main goal: introduce
Reservationdata class containing all information XPK reads from the GCE Reservation resource.Other changes:
ReservationLink. Easily cache-able.count,inUseCount), but I'll need it soon.READYstatus are treated as incorrect, previously we didn't check that.Reservations API reference: https://docs.cloud.google.com/compute/docs/reference/rest/v1/reservations.
Issue
Part of b/477114712.
I need this change to focus on business logic in the better reservations handling logic, where I'll ensure Reservation capacities and machines types are correct.
Testing