Open
Conversation
gabesaba
reviewed
Feb 10, 2026
Comment on lines
-368
to
+369
| log = log.WithValues("slice", klog.KObj(&slice)) | ||
| log = log.WithValues("slice", klog.KObj(slice)) |
Collaborator
There was a problem hiding this comment.
I don't see how this is any different?
Collaborator
There was a problem hiding this comment.
Is there another place where we were passing the []slice, and now pass []*slice?
Collaborator
Author
There was a problem hiding this comment.
yes, exactly. In the lines displaying log "Waiting for Slices to be initialized" (or "Deleting Slices" or "Waiting for deleted Slices to be cleaned up") are calling klog.KObjSlice(grouped.initializing), but since grouped.initializing contained Slices (and not *Slices) it was displaying an error message "KObjSlice needs a slice of values implementing KMetadata, got type v1beta1.Slice" instead of anything useful.
I think it makes more sense to just change groupedSlices to be a struct of pointer slices.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is to fix the error in logs "KObjSlice needs a slice of values implementing KMetadata, got type v1beta1.Slice" which is due to the fact that we were passing a Slice object, instead of *Slice to the KObjSlice function.
Issue
Testing