Conversation
- Sanitize Mermaid SVG output using DOMPurify before innerHTML assignment. - Configure DOMPurify to allow foreignObject (for HTML labels) and target attribute. - Install dompurify and @types/dompurify dependencies. Co-authored-by: 7sg56 <102475617+7sg56@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
✅ Deploy Preview for colduml ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
1 participant
This PR fixes a critical security vulnerability where Mermaid diagrams were rendered directly into the DOM using innerHTML without sanitization.
Vulnerability
The
SimplePreviewcomponent was taking user input (Mermaid code), rendering it to SVG, and then settinginnerHTMLdirectly. Since Mermaid'ssecurityLevelis set toloose, this allowed malicious payloads (e.g.,<img src=x onerror=alert(1)>) to be injected and executed.Solution
We introduced
dompurifyto sanitize the SVG string before insertion. The sanitization is configured to:foreignObjecttags, which are necessary for Mermaid's HTML labels.targetattribute.Verification
PR created automatically by Jules for task 490713295524379380 started by @7sg56