Skip to content

Fix broken back button when viewing a recipe #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msp301 wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Fix broken back button when viewing a recipe #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c8f1278
Update NoSleep to fix error when viewing recipe
msp301 Feb 4, 2022
dc69f5b
Update bundle
msp301 Feb 4, 2022
8dc3c9d
Suppress Svelte warning: <Back> created without expected prop
msp301 Feb 4, 2022
2e352f3
Use maskable icons in manifest to improve look when installed
msp301 Feb 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 37 additions & 16 deletions manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,48 @@
{
"name": "2Brew",
"short_name": "2Brew",
"icons": [{
"src": "public/icon/icon_128x128.png",
"icons": [
{
"src": "public/icon/maskable_icon_48x48.png",
"sizes": "48x48",
"type": "image/png",
"purpose": "any maskable"
},
{
"src": "public/icon/maskable_icon_72x72.png",
"sizes": "72x72",
"type": "image/png",
"purpose": "any maskable"
},
{
"src": "public/icon/maskable_icon_96x96.png",
"sizes": "96x96",
"type": "image/png",
"purpose": "any maskable"
},
{
"src": "public/icon/maskable_icon_128x128.png",
"sizes": "128x128",
"type": "image/png"
}, {
"src": "public/icon/icon_144x144.png",
"sizes": "144x144",
"type": "image/png"
}, {
"src": "public/icon/icon_152x152.png",
"sizes": "152x152",
"type": "image/png"
}, {
"src": "public/icon/icon_192x192.png",
"type": "image/png",
"purpose": "any maskable"
},
{
"src": "public/icon/maskable_icon_192x192.png",
"sizes": "192x192",
"type": "image/png"
"type": "image/png",
"purpose": "any maskable"
},
{
"src": "public/icon/maskable_icon_384x384.png",
"sizes": "384x384",
"type": "image/png",
"purpose": "any maskable"
},
{
"src": "public/icon/icon_512x512.png",
"src": "public/icon/maskable_icon_512x512.png",
"sizes": "512x512",
"type": "image/png"
"type": "image/png",
"purpose": "any maskable"
}
],
"start_url": "/",
Expand Down
6 changes: 3 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"svelte-spa-router": "^2.1.0"
},
"dependencies": {
"nosleep.js": "^0.11.0",
"nosleep.js": "^0.12.0",
"sirv-cli": "^0.4.4"
}
}
2 changes: 1 addition & 1 deletion public/build/bundle.css.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion public/build/bundle.js
View file
Open in desktop

Large diffs are not rendered by default.

Binary file added public/icon/maskable_icon_128x128.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/icon/maskable_icon_192x192.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/icon/maskable_icon_384x384.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/icon/maskable_icon_48x48.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/icon/maskable_icon_512x512.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/icon/maskable_icon_72x72.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added public/icon/maskable_icon_96x96.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
2 changes: 1 addition & 1 deletion src/components/Back.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<script>
import {push, link} from 'svelte-spa-router'
export let href;
export let nomargin;
export let nomargin = undefined;
Copy link
Author

@msp301 msp301 Feb 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very familiar with Svelte, is nomargin needed anymore?
I've suppressed the following warning by "setting" nomargin here: <Back> created without expected prop 'nomargin'

</script>

<div class="back">
Expand Down