Use full integration time when calculating nrTimSamps in on_pointing_axis_tracking#9
Open
David-McKenna wants to merge 1 commit into2baOrNot2ba:masterfrom
Open
Use full integration time when calculating nrTimSamps in on_pointing_axis_tracking#9David-McKenna wants to merge 1 commit into2baOrNot2ba:masterfrom
David-McKenna wants to merge 1 commit into2baOrNot2ba:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Tobia,
Not sure if this was intentional or not, but I found that on_pointing_axis_tracking was not returning the amount of time steps I expected, and ended up tracking it down to a TimeDelta division where only the number of seconds were being used to determine the time step, discarding fractions of seconds (div by 0 error for < 1 second), or minutes/hours/etc (producing far too many time steps as a result).
This is a quick PR that fixes that issue, and changes the TimeDelta.seconds variable to TimeDelta.total_seconds() for increased accuracy when determiningthe number of requested time samples.
Cheers,
David