Merged
Conversation
Add benchmark suite covering stream, channel, and workerpool packages: - Stream: FromSlice, Filter, Map, ChainedOps, ToSlice, ForEach, Reduce - Channel: Send/Receive, contention levels, backpressure strategies - WorkerPool: Submit, throughput, contention, scaling, shutdown Add `make benchmark` target for comprehensive reporting.
Reduce lock contention in hot path by using atomic.Int64 for counters: - totalExecutions, successfulRuns, failedRuns, totalDuration Mutex now only protects complex data structures (lastExecutionAt, stageStats). Stats() reads atomics lock-free, then briefly locks for map copy. This improves throughput under concurrent pipeline execution.
- Fix contentionLabel in channel_bench_test.go to handle values >= 100
- Fix workerLabel in workerpool_bench_test.go to handle workers >= 10
The previous implementation used string(rune('0'+n)) which only works
for single-digit numbers. Using strconv.Itoa handles all integer values
correctly.
Collaborator
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Performance optimizations and code quality improvements for the goflow library. Non-breaking changes only.
Changes
Phase 1: Benchmark Suite
internal/benchmark/with comprehensive benchmarksmake benchmarktargetPhase 2: Atomic Pipeline Stats
sync/atomicfor counters (TotalExecutions, SuccessfulRuns, FailedRuns, TotalDuration)Phase 3: Code Cleanup
%wfor errors)Code Review Fix
strconv.Itoafor values >= 10Benchmark Baseline (captured)
Test Plan
-raceflagmake benchmarkproduces comprehensive reportChecklist