Fix: detecting fragment usage in maskFragments()#379
Merged
JoviDeCroock merged 3 commits into0no-co:mainfrom Dec 9, 2025
Merged
Fix: detecting fragment usage in maskFragments()#379JoviDeCroock merged 3 commits into0no-co:mainfrom
JoviDeCroock merged 3 commits into0no-co:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 214d770 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
takumiyoshikawa
commented
Dec 9, 2025
| if (!ts.isCallExpression(node)) return false; | ||
| if (!ts.isIdentifier(node.expression)) return false; | ||
| // Only checks function name, not whether it's from gql.tada | ||
| return node.expression.escapedText === 'maskFragments'; |
Contributor
Author
There was a problem hiding this comment.
Currently, we only check whether maskFragments is being used by looking at the function name.
I’d like to improve this if there’s a better approach, but I haven’t found a good solution yet.
JoviDeCroock
approved these changes
Dec 9, 2025
JoviDeCroock
reviewed
Dec 9, 2025
Co-authored-by: Jovi De Croock <decroockjovi@gmail.com>
Contributor
Author
|
Thank you for the review. I’ve updated the commit suggestion accordingly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I have reported the following issue to the gql.tada repository.
0no-co/gql.tada#500
Summary
When using
gql.tada'smaskFragments()function, the colocated fragments check was incorrectly reporting fragments asunused, even though they were being used.
This PR fixes the false positive by detecting fragment usage in
maskFragments()calls.Example
Changes
Test plan