-
Notifications
You must be signed in to change notification settings - Fork 17
feat: add bonus scoring for ":heart: xeno" and "feedback" labels #3181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: antonkovalenko <692649+antonkovalenko@users.noreply.github.com>
.github/workflows/priority-score.yml
Outdated
| bonusScore += defaultReach; | ||
| } | ||
| let finalScore = baseScore + bonusScore; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace addition with multiplication please
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 96bff99. Changed to multiplication - bonus multiplier now starts at 1 and multiplies by defaultImpact/defaultReach when respective labels are present.
antonkovalenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace + with *
Co-authored-by: antonkovalenko <692649+antonkovalenko@users.noreply.github.com>
.github/workflows/priority-score.yml
Outdated
| if (effortWeights[label] !== undefined) { | ||
| effort = effortWeights[label]; | ||
| } | ||
| if (label === "heart xeno") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure this will work - correct label name is inside quotes: ":heart: xeno"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in 8348391. Changed the label name to ":heart: xeno".
antonkovalenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
address my comment about
I am not sure this will work - correct label name is inside quotes: ":heart: xeno"
Co-authored-by: antonkovalenko <692649+antonkovalenko@users.noreply.github.com>
antonkovalenko
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds bonus scoring functionality to the GitHub issue priority calculation workflow by introducing multipliers for ":heart: xeno" and "feedback" labels. The implementation multiplies the base priority score by 75 for each label (5625 if both are present).
Key changes:
- Bonus multipliers for special labels (":heart: xeno" and "feedback")
- Refactored score calculation to separate base score from final score with multipliers
- Enhanced logging to show multiplier breakdown
.github/workflows/priority-score.yml
Outdated
| bonusMultiplier *= defaultReach; | ||
| } | ||
| let finalScore = baseScore * bonusMultiplier; |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The finalScore result can become extremely large (potentially millions) and may not fit within the expected range for the CalculatedPriority field. Consider adding validation or capping the maximum score to prevent GraphQL mutation failures or UI display issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already addressed in 2c5a554. Added MAX_PRIORITY_SCORE = 100000 cap using Math.min() to prevent excessively large values.
.github/workflows/priority-score.yml
Outdated
| if (hasHeartXeno) { | ||
| bonusMultiplier *= defaultImpact; | ||
| } | ||
| if (hasFeedback) { | ||
| bonusMultiplier *= defaultReach; |
Copilot
AI
Dec 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The magic numbers 75 (defaultImpact and defaultReach) are used as multipliers without clear justification. These values are hardcoded and duplicate the default values above. Consider extracting these as named constants with clear intent, such as HEART_XENO_MULTIPLIER and FEEDBACK_MULTIPLIER, to improve maintainability and make it easier to adjust these values in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot apply changes based on this feedback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Already addressed in 2c5a554. Extracted multiplier values as named constants: HEART_XENO_MULTIPLIER = 1.5 and FEEDBACK_MULTIPLIER = 1.5.
|
@copilot apply changes based on the comments in this thread |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: antonkovalenko <692649+antonkovalenko@users.noreply.github.com>
Head branch was pushed to by a user without write access
Applied the reviewer suggestions in 2c5a554:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
Priority score calculation now treats ":heart: xeno" and "feedback" labels as bonus multipliers.
Changes
Formula
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
CI Results
Test Status:⚠️ FLAKY
📊 Full Report
Test Changes Summary ⏭️2
⏭️ Skipped Tests (2)
Bundle Size: ✅
Current: 62.34 MB | Main: 62.34 MB
Diff: 0.00 KB (0.00%)
✅ Bundle size unchanged.
ℹ️ CI Information