Skip to content

Albert/support mistral3 architecture #523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
albertkawmi wants to merge 1 commit into from
Closed

Albert/support mistral3 architecture #523

albertkawmi wants to merge 1 commit into from

Conversation

@albertkawmi
Copy link

@albertkawmi albertkawmi commented Dec 3, 2025

Description of change

This is a two-line change to add support for the new mistral3 model architecture.

I had to branch off a WIP branch, so this is not yet ready to merge. I will leave it as a draft PR and come back to it once the WIP is complete.

Did a quick test and it seems to work:

Screenshot 2025-12-03 at 23 18 19

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply eslint formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits and pull request title follow conventions explained in pull request guidelines (PRs that do not follow this convention will not be merged)

@albertkawmi
feat: add suport for mistral3 models
7792a87 
Mistral released a new series of models with a new `mistral3` architecture.

This commit updates the `GgufArchitectureType` so include `mistral3`.

This was tested with Ministral-3-3B-Instruct-2512-Q4_K_M.gguf
@albertkawmi albertkawmi changed the base branch from master to gilad/adaptToLlamaCppChanges December 3, 2025 23:33
@giladgd giladgd deleted the branch withcatai:gilad/adaptToLlamaCppChanges December 4, 2025 01:13
@giladgd giladgd closed this Dec 4, 2025
@giladgd
Copy link
Member

giladgd commented Dec 4, 2025

Thanks for the PR!
It seems it got closed because I merged the branch you targeted to master.
Feel free to open another PR to master instead

@albertkawmi
Copy link
Author

albertkawmi commented Dec 4, 2025

I've opened #524 instead of this 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@albertkawmi @giladgd