Skip to content

Conversation

@gcanlin
Copy link
Contributor

@gcanlin gcanlin commented Dec 5, 2025

What this PR does / why we need it?

In vllm-omni, we create the empty VllmConfig, which raised the null error in vllm-ascend/vllm_ascend/utils.py. More details are here.

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a null check for vllm_config in the is_vl_model function to prevent a potential AttributeError. The change is correct and improves the robustness of the code. However, the fix is incomplete as it doesn't check for vllm_config.model_config.hf_config before use, which could still lead to an AttributeError. I've added a comment with a suggestion to make the check more comprehensive. Additionally, a similar issue exists in the is_moe_model function which could also be addressed for consistency.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@wangxiyuan wangxiyuan merged commit 2b819bb into vllm-project:main Dec 9, 2025
27 checks passed
weijinqian0 pushed a commit to weijinqian0/vllm-ascend that referenced this pull request Dec 9, 2025
### What this PR does / why we need it?

In vllm-omni, we create the empty `VllmConfig`, which raised the null
error in
[`vllm-ascend/vllm_ascend/utils.py`](https://github.com/vllm-project/vllm-ascend/blob/a7f91079b8576a846f671c9e6923805e74e35c87/vllm_ascend/utils.py#L833).
More details are
[here](vllm-project/vllm-omni#208).

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?


- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
weijinqian0 pushed a commit to weijinqian0/vllm-ascend that referenced this pull request Dec 9, 2025
### What this PR does / why we need it?

In vllm-omni, we create the empty `VllmConfig`, which raised the null
error in
[`vllm-ascend/vllm_ascend/utils.py`](https://github.com/vllm-project/vllm-ascend/blob/a7f91079b8576a846f671c9e6923805e74e35c87/vllm_ascend/utils.py#L833).
More details are
[here](vllm-project/vllm-omni#208).

### Does this PR introduce _any_ user-facing change?

### How was this patch tested?

- vLLM version: v0.12.0
- vLLM main:
vllm-project/vllm@ad32e3e

Signed-off-by: gcanlin <canlinguosdu@gmail.com>
Signed-off-by: weijinqian_v1 <weijinqian@huawei.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants