Figure out why redists don't install

[utkarshdalal]

On first launch of a container, we automatically install all redists from the A:_CommonRedists folder. This seems to proceed without any errors, however, when opening the container it appears as though they are not actually installed.
Investigate why this is happening and fix it.

[phobos665]

So I think this is a bit two-fold:

• I don't think we are applying the correct execution arguments to install these.
• We don't do enough heuristic scanning to check for the VCRedists outside of a very small selection.

Take this for example:

Snippet from GOG's dependency manifests:

            "compressedSize": 2684678,
            "dependencyId": "MSVC2005",
            "executable": {
                "arguments": "/q:a /c:\"VCREDI~3.EXE /q:a /c:\"\"msiexec /i vcredist.msi /qb\"\" \"",
                "path": "__redist/MSVC2005/vcredist_x86.exe"
            },
            "internal": false,
            "languages": [
                "*"
            ],
            "manifest": "REDACTED",
            "readableName": "Visual C++ Redist 2005",
            "signature": "REDACTED",
            "size": 2723264
        },

As you can see, this one would be two-fold where:

• It doesn't pick up the correct folder (and thus file)
• It's missing the arguments expected. (Although some of these aren't as helpful as others.

Another example:

"dependencyId": "MSVC2008",
            "executable": {
                "arguments": "/q",
                "path": "__redist/MSVC2008/vcredist_x86.exe"
            }

[utkarshdalal]

i think even in the case where we do find the right redists, they don't install though

[utkarshdalal]

what do you suggest re the arguments?

[phobos665]

what do you suggest re the arguments?

I think it's worth us reviewing the GOG's dependency list to see how they're installing the dependencies quietly, and see how well that performs. It'd a case-by-case unfortunately.

Do we know which ones specifically are having issues?