-
Notifications
You must be signed in to change notification settings - Fork 94
Add support for single layer board #1688
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| // Verify that allLayers returns only ["top"] | ||
| const boardComponent = circuit.firstChild | ||
| expect(boardComponent).not.toBeNull() | ||
| if (boardComponent && "allLayers" in boardComponent) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't put this type of assertion in a test never use if conditions with expect in tests
seveibar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this should throw an error, smtpads aren't allowed on the bottom layer when only the top layer has copper
when components are put on the bottom layer, they must be through hole (plated holes)
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs. |
|
This PR was closed because it has been inactive for 1 day since being marked as stale. |
No description provided.