Skip to content

Conversation

@techmannih
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Nov 28, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
tscircuit-core-benchmarks Ready Ready Preview Comment Dec 2, 2025 5:21pm

// Verify that allLayers returns only ["top"]
const boardComponent = circuit.firstChild
expect(boardComponent).not.toBeNull()
if (boardComponent && "allLayers" in boardComponent) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't put this type of assertion in a test never use if conditions with expect in tests

Copy link
Contributor

@seveibar seveibar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should throw an error, smtpads aren't allowed on the bottom layer when only the top layer has copper

when components are put on the bottom layer, they must be through hole (plated holes)

@github-actions
Copy link

github-actions bot commented Dec 1, 2025

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions
Copy link

github-actions bot commented Dec 5, 2025

This PR has been automatically marked as stale because it has had no recent activity. It will be closed if no further activity occurs.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

This PR was closed because it has been inactive for 1 day since being marked as stale.

@github-actions github-actions bot closed this Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants