Skip to content

Commit dd8d24a

Browse files
committed
remove unnecessary instance variable
1 parent 6241505 commit dd8d24a

File tree

1 file changed

+5
-8
lines changed

1 file changed

+5
-8
lines changed

src/main/java/org/embulk/output/SnowflakeOutputPlugin.java

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@
2323
import org.embulk.util.config.ConfigDefault;
2424

2525
public class SnowflakeOutputPlugin extends AbstractJdbcOutputPlugin {
26-
private StageIdentifier stageIdentifier;
27-
2826
public interface SnowflakePluginTask extends PluginTask {
2927
@Config("driver_path")
3028
@ConfigDefault("null")
@@ -139,21 +137,21 @@ public ConfigDiff transaction(
139137
ConfigSource config, Schema schema, int taskCount, OutputPlugin.Control control) {
140138
PluginTask task = CONFIG_MAPPER.map(config, this.getTaskClass());
141139
SnowflakePluginTask t = (SnowflakePluginTask) task;
142-
this.stageIdentifier = StageIdentifierHolder.getStageIdentifier(t);
140+
StageIdentifier stageIdentifier = StageIdentifierHolder.getStageIdentifier(t);
143141
ConfigDiff configDiff;
144142
SnowflakeOutputConnection snowflakeCon = null;
145143

146144
try {
147145
snowflakeCon = (SnowflakeOutputConnection) getConnector(task, true).connect(true);
148-
snowflakeCon.runCreateStage(this.stageIdentifier);
146+
snowflakeCon.runCreateStage(stageIdentifier);
149147
configDiff = super.transaction(config, schema, taskCount, control);
150148
if (t.getDeleteStage()) {
151-
snowflakeCon.runDropStage(this.stageIdentifier);
149+
snowflakeCon.runDropStage(stageIdentifier);
152150
}
153151
} catch (Exception e) {
154152
if (t.getDeleteStage() && t.getDeleteStageOnError()) {
155153
try {
156-
snowflakeCon.runDropStage(this.stageIdentifier);
154+
snowflakeCon.runDropStage(stageIdentifier);
157155
} catch (SQLException ex) {
158156
throw new RuntimeException(ex);
159157
}
@@ -185,11 +183,10 @@ protected BatchInsert newBatchInsert(PluginTask task, Optional<MergeConfig> merg
185183
"Snowflake output plugin doesn't support 'merge_direct' mode.");
186184
}
187185
SnowflakePluginTask pluginTask = (SnowflakePluginTask) task;
188-
this.stageIdentifier = StageIdentifierHolder.getStageIdentifier(pluginTask);
189186

190187
return new SnowflakeCopyBatchInsert(
191188
getConnector(task, true),
192-
this.stageIdentifier,
189+
StageIdentifierHolder.getStageIdentifier(pluginTask),
193190
false,
194191
pluginTask.getMaxUploadRetries(),
195192
pluginTask.getEmtpyFieldAsNull());

0 commit comments

Comments
 (0)