-
Notifications
You must be signed in to change notification settings - Fork 844
feat(google_generativeai): Added support for Google ADK #3490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request adds support for Google ADK instrumentation by introducing a new enum member Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related issues
Possibly related PRs
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (2)
🧰 Additional context used📓 Path-based instructions (1)**/*.py📄 CodeRabbit inference engine (CLAUDE.md)
Files:
🧬 Code graph analysis (1)packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py (3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
🔇 Additional comments (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Important
Looks good to me! 👍
Reviewed everything up to 3f6b79f in 1 minute and 33 seconds. Click for details.
- Reviewed
41lines of code in2files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. packages/traceloop-sdk/traceloop/sdk/instruments.py:13
- Draft comment:
Added enum value 'GOOGLE_ADK'. Ensure its naming/documentation aligns with the package (google-adk). - Reason this comment was not posted:
Comment looked like it was already resolved.
2. packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py:496
- Draft comment:
Updated instrumentation check to include GOOGLE_ADK. Logic is clear and correctly combines both supported enum values. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is purely informative, as it only states that the logic is clear and correctly combines supported enum values. It doesn't provide any actionable feedback or suggestions for improvement.
3. packages/traceloop-sdk/traceloop/sdk/tracing/tracing.py:707
- Draft comment:
Extended package check to include 'google-adk'. Note: the error log still mentions 'Gemini instrumentor' which seems like a copy-paste error. Consider updating it. - Reason this comment was not posted:
Comment was on unchanged code.
Workflow ID: wflow_CsXW26SsbM7VP6XX
You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.
feat(instrumentation): ...orfix(instrumentation): ....Important
Add support for Google ADK by updating
Instrumentsenum andinit_instrumentations()function.GOOGLE_ADKtoInstrumentsenum ininstruments.py.init_instrumentations()intracing.pyto initializeGOOGLE_ADKusinginit_google_generativeai_instrumentor().init_google_generativeai_instrumentor()now checks forgoogle-adkpackage installation.This description was created by
for 3f6b79f. You can customize this summary. It will automatically update as commits are pushed.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.