Skip to content

Commit d0a5e6d

Browse files
committed
fix: respond to appeals
1 parent 12c4c64 commit d0a5e6d

File tree

2 files changed

+4
-11
lines changed

2 files changed

+4
-11
lines changed

src/apps/review/src/pages/reviews/components/ReviewViewer/ReviewViewer.tsx

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,6 @@ import styles from './ReviewViewer.module.scss'
2727
const ReviewViewer: FC = () => {
2828
const navigate = useAppNavigate()
2929
const [searchParams] = useSearchParams()
30-
const respondToAppeals = searchParams.get('respondToAppeals') === 'true'
3130
const [initialLoad, setInitialLoad] = useState(false)
3231
const {
3332
reviewId,
@@ -44,7 +43,8 @@ const ReviewViewer: FC = () => {
4443
}: useRoleProps = useRole()
4544
const [showCloseConfirmation, setShowCloseConfirmation] = useState<boolean>(false)
4645
const [isChanged, setIsChanged] = useState(false)
47-
const [isManagerEdit, setIsManagerEdit] = useState(false)
46+
const respondToAppeals = searchParams.get('respondToAppeals') === 'true'
47+
const [isManagerEdit, setIsManagerEdit] = useState(respondToAppeals)
4848

4949
const {
5050
challengeInfo,
@@ -207,17 +207,10 @@ const ReviewViewer: FC = () => {
207207
])
208208

209209
useEffect(() => {
210-
if (!canEditScorecard && isManagerEdit) {
210+
if (!canEditScorecard && isManagerEdit && !respondToAppeals) {
211211
setIsManagerEdit(false)
212212
}
213-
}, [canEditScorecard, isManagerEdit])
214-
215-
useEffect(() => {
216-
if (!initialLoad && respondToAppeals) {
217-
setIsManagerEdit(true)
218-
setInitialLoad(true)
219-
}
220-
}, [isManagerEdit, respondToAppeals, initialLoad])
213+
}, [canEditScorecard, isManagerEdit, respondToAppeals])
221214

222215
const toggleManagerEdit = useCallback(() => {
223216
setIsManagerEdit(prev => !prev)

start.sh

100755100644
File mode changed.

0 commit comments

Comments
 (0)