Merge pull request #1384 from topcoder-platform/pm-2666_1

fix(PM-2666): Filtered submissions in checkpoint review tab based on screening result

Author: hentrymartin

src/apps/review/src/lib/components/ChallengeDetailsContent/TabContentCheckpoint.tsx

@@ -1,7 +1,7 @@
 /**
  * Content of checkpoint tab.
  */
-import { FC, useContext, useMemo } from 'react'
+import { FC, useCallback, useContext, useMemo } from 'react'
 
 import { TableLoading } from '~/apps/admin/src/lib'
 import { IsRemovingType } from '~/apps/admin/src/lib/models'
@@ -75,6 +75,32 @@ export const TabContentCheckpoint: FC<Props> = (props: Props) => {
         [props.checkpointReview, myMemberIds, props.checkpointReviewMinimumPassingScore],
     )
 
+    const checkpointScreeningOutcome = useMemo(
+        () => {
+            const passingSubmissionIds = new Set<string>()
+            const failingSubmissionIds = new Set<string>()
+
+            props.checkpoint.forEach(entry => {
+                if (!entry?.submissionId) {
+                    return
+                }
+
+                const normalizedResult = (entry.result || '').toUpperCase()
+                if (normalizedResult === 'PASS') {
+                    passingSubmissionIds.add(`${entry.submissionId}`)
+                } else if (normalizedResult === 'NO PASS') {
+                    failingSubmissionIds.add(`${entry.submissionId}`)
+                }
+            })
+
+            return {
+                failingSubmissionIds,
+                passingSubmissionIds,
+            }
+        },
+        [props.checkpoint],
+    )
+
     const filteredCheckpoint = useMemo<Screening[]>(
         () => {
             const baseRows = props.checkpoint ?? []
@@ -107,9 +133,15 @@ export const TabContentCheckpoint: FC<Props> = (props: Props) => {
         ],
     )
 
+    const filterCheckpointReviewByScreeningResult = useCallback(
+        (screening: Screening[]) => screening
+            .filter(row => checkpointScreeningOutcome.passingSubmissionIds.has(`${row.submissionId}`)),
+        [checkpointScreeningOutcome],
+    )
+
     const filteredCheckpointReview = useMemo<Screening[]>(
         () => {
-            const baseRows = props.checkpointReview ?? []
+            const baseRows = filterCheckpointReviewByScreeningResult(props.checkpointReview ?? [])
 
             if (isPrivilegedRole || (isChallengeCompleted && hasPassedCheckpointReviewThreshold)) {
                 return baseRows
@@ -135,6 +167,7 @@ export const TabContentCheckpoint: FC<Props> = (props: Props) => {
             hasPassedCheckpointReviewThreshold,
             checkpointReviewerResourceIds,
             myMemberIds,
+            checkpointScreeningOutcome,
         ],
     )